Yamcs Tech Debt Cleanup

[dmitri-mcguckin]

While investigating Issue #53, more problematic issues with implementation came up.

• EDL Packets are assumed to be created with the correct length
• HMAC Keys are still loaded from environment variables
• Many constructors call their parent constructors with child functions and with no error checking whatsoever

In addition to other missing features, such as storing sequence numbers in YDB.

---

 

This issue is intended to be an Epic for tracking multiple fixes (may be broken into multiple issues later) that need to be implemented, including:

• Store HMAC keys in Yarch DB
• Store Sequence Numbers in Yarch DB
• Remove redundant packet classes (potentially convert common packet functions to a common PacketUtils static class)
• Implement packet assertion checks both on ingress and egress