-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/sitecore 10 xm #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
asiaboron
commented
May 24, 2023
- Sitecore upgraded from 9.3 to 10.3
- XP-only features removed (XM compatibility achieved)
- minor improvements in *.config files for easier updates in non-Bob folder structure
Joanna Boroń seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes overall look good to me. But as explained in my other comment, I think we cannot just remove support for the XP features which where there before. Since the module is now open source, we cannot be sure which other projects besides our own do use the module. I therefore suggest to migrate the XP dependent features/files into a separate package/projects which can be installed on XP projects optionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem: removing these files will break backwards compatibility with installations on XP which may use these rules. It may be a better option to create a /support/XM branch instead of deleting the files on the main branch .
Or (probably the better) alternatively: create a separate package for the XP support and move the files there. E.g. Unic.Flex.ExpiriencePlatform or Unic.Flex.XP