Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

717 Taking notes associated with nodes and edges #748

Open
wants to merge 196 commits into
base: master
Choose a base branch
from

Conversation

TimDinh-hub
Copy link
Collaborator

@TimDinh-hub TimDinh-hub commented Jul 1, 2024

This pull request introduces a new note management feature that allows users to create, edit, extend, delete, and toggle visibility of notes for selected nodes and edges. Additionally, notes can be saved and loaded, and they support both private and public visibility modes. The following functionalities are included:

  • Create and manage notes:
    • The user can create a note by right-clicking on a node/edge and pressing "Create note".
    • By creating a new note, the node/edge will be marked with an outline.
    • If a note already exists, the saved content is loaded.
    • When the user opens a note window, a new window with 5 buttons appears on the side:
      1. Save button - Save the content to a file.
      2. Load button - Load the content from a file to the currently active note window.
      3. Delete button - Deletes the content.
      4. Refresh button - Loads the new content if it got change by another client.
      5. Toggle button - A toggle button to specify if you want the note public or private.
  • Toggle Note Visibility:
    • The user can choose to show or hide the outlines of the nodes/edges by changing their Action to "Note"
    • You can click the middle mouse button to hide/show all the outlines. Alternatively you can click on the nodes/edges one by one.

Cyclone1337 and others added 30 commits July 26, 2023 14:12
This plugin requires a commercial license.
If an action has a visible effect but is not yet completed, currentState must be InProgress.

Added FIXME markers.

Shortened long lines.

We can use the new new() operator without type if the type
is statically known.

Removed trailing whitespace.
When the action history is empty, we will reset the menu to its
top level.
@TimDinh-hub TimDinh-hub linked an issue Jul 1, 2024 that may be closed by this pull request
5 tasks
Copy link
Collaborator

@koschke koschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all your accidental changes in Assets/Plugins and Assets/Resources.

Apparently, you have branched from branch whiteboard. Now your own additions are burried in the list of the changes made by @Cyclone1337. The branch whiteboard is still work in progress. I would prefer to merge your branch after branch whiteboard is merged.

.vsconfig Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few bad patterns I found which you should check.

Assets/SEE/UI/Window/NoteWindow/NoteButtonWindow.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taking notes associated with nodes and edges.
3 participants