Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Mode Selection menu should also be closeable through pressing Esc or Space key #705

Closed
azimc opened this issue Feb 15, 2024 · 0 comments · Fixed by #707
Closed

The Mode Selection menu should also be closeable through pressing Esc or Space key #705

azimc opened this issue Feb 15, 2024 · 0 comments · Fixed by #707
Assignees
@falko17 @azimc
Labels
bug Something isn't working
Milestone
Axivion1

Comments

@azimc
Copy link
Collaborator

azimc commented Feb 15, 2024

The mode selection menu is currently only closeable through moving the laser beam towards the buttons "Back" and "Close",
Intuitively speaking, it should also be closeable through pressing the Esc or Space key.
@azimc azimc added the enhancement New feature or request label Feb 15, 2024
@azimc azimc added this to the Axivion1 milestone Feb 15, 2024
@azimc azimc self-assigned this Feb 15, 2024
@falko17 falko17 added bug Something isn't working and removed enhancement New feature or request labels Feb 15, 2024
falko17 added a commit that referenced this issue Feb 15, 2024
@falko17
Fix #705
42ea3f7 
Previously, keyboard shortcuts were
disabled whenever the menu was open.
This commit disables the keyboard shortcuts
only while the input field is focussed,
as otherwise, no keyboard shortcuts are used.
@falko17 falko17 self-assigned this Feb 16, 2024
falko17 added a commit that referenced this issue Feb 16, 2024
@falko17
Fix #705
85eb8d1
@falko17 falko17 mentioned this issue Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@falko17 falko17

@azimc azimc

Labels
bug Something isn't working
Projects
None yet
Milestone
Axivion1
Development

Successfully merging a pull request may close this issue.

Fix player menu issues uni-bremen-agst/SEE
2 participants
@falko17 @azimc