Skip to content
This repository was archived by the owner on Apr 3, 2023. It is now read-only.

Conversation

@TeddyRoncin
Copy link
Member

@TeddyRoncin TeddyRoncin commented Feb 3, 2023

…h library fakerphp/faker

Description

Checklist

Test

Implementation

  • Files and variables have a name explaining what they do.
  • Updating the DB schemas and seeding the tables do not generates errors.
  • All code repeted more than 2 times has been refactored in a dedicated file or function.
  • Debugs have been removed : dd() | dump()

Tools

  • PHP CS Fixer has fixed all files inside the src folder.
  • All commits have been done using Commitizen.

Documentation

  • All new classes and non-trivial functions have a code documentation.
  • There are comments to explain complex parts inside your code.
  • If a new folder is created, it has been added and explained inside the "Folder structure" part of the README.md file.

@TeddyRoncin TeddyRoncin requested a review from Younnsss February 3, 2023 23:24
@TeddyRoncin TeddyRoncin merged commit c69ecdf into dev Feb 20, 2023
@TeddyRoncin TeddyRoncin deleted the lib/fzaninotto-to-fakerphp branch February 20, 2023 11:45
TeddyRoncin added a commit that referenced this pull request Feb 26, 2023
TeddyRoncin added a commit that referenced this pull request Feb 26, 2023
TeddyRoncin added a commit that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants