Skip to content

Feature/alignment search 3.4.0#7440

Merged
PhotoNomad0 merged 24 commits intorelease-v3.4.0-Searchfrom
feature-mcleanb-searchAlignments
Nov 17, 2022
Merged

Feature/alignment search 3.4.0#7440
PhotoNomad0 merged 24 commits intorelease-v3.4.0-Searchfrom
feature-mcleanb-searchAlignments

Conversation

@PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Oct 11, 2022

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature/alignment search WIP: Feature/alignment search 3.4.0 Oct 23, 2022
@PhotoNomad0 PhotoNomad0 changed the base branch from release-v3.4.0 to release-v3.4.0-Search November 17, 2022 20:16
@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature/alignment search 3.4.0 Feature/alignment search 3.4.0 Nov 17, 2022
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review November 17, 2022 20:16
@PhotoNomad0 PhotoNomad0 merged commit 4bfa2af into release-v3.4.0-Search Nov 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature-mcleanb-searchAlignments branch November 17, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant