Skip to content

don't show link if readonly URLField is None #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

don't show link if readonly URLField is None #1446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/unfold/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def _get_contents(self) -> str:
result_repr = display_for_field(value, f, self.empty_value_display)
return conditional_escape(result_repr)
elif isinstance(f, models.URLField):
return format_html(
return value and format_html(
'<a href="{}" class="text-primary-600 dark:text-primary-500">{}</a>',
value,
value,
Expand Down