Fix addon filtering when no category present #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@gmail.com>
Owner
|
Thanks for this! Love that you've put effort into the tests. I should be able to take a look some time this week. |
steven-sheehy
commented
Nov 24, 2025
| <rom name="Test Title 51 (USA) (Addon).bin" size="1000" crc="00000000" md5="00000000000000000000000000000000" sha1="0000000000000000000000000000000000000000"/> | ||
| </game> | ||
| <game name="Test Title 52 (USA) (DLC)"> | ||
| <description>TTest Title 52 (USA) (DLC)</description> |
Author
There was a problem hiding this comment.
Whoops, just noticed the extra T. Will address soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes add-on category filter when there's no
<category>addon</category>in the DAT like in No-Intro. The add-ons should be filtered using keywords in the title that are wrapped in parenthesis like(DLC)or(Addon).The exclusions test didn't work on main but I made a stab at making them work and adding tests.
Fixes #359