Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop checking in the bundled files #272

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Stop checking in the bundled files #272

merged 1 commit into from
Jun 15, 2019

Conversation

sunesimonsen
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jun 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1154

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.463%
Totals Coverage Status
Change from base Build 1141: 0.0%
Covered Lines: 654
Relevant Lines: 683
💛 - Coveralls

@alexjeffburke
Copy link
Member

Do we need to adjust the current “preversion”
npm script to something like “prepublishOnly” and remove git add?

@sunesimonsen
Copy link
Member Author

@alexjeffburke good point, I'll check it out.

@sunesimonsen sunesimonsen force-pushed the ssimonsen/stop-checking-in-bundled-files branch from 6ed7ec4 to ed82ca0 Compare June 15, 2019 09:02
@sunesimonsen
Copy link
Member Author

@alexjeffburke I updated the PR to only build and bundle in prepublishOnly.

@sunesimonsen sunesimonsen merged commit 11b6b18 into master Jun 15, 2019
@sunesimonsen sunesimonsen deleted the ssimonsen/stop-checking-in-bundled-files branch June 15, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjeffburke alexjeffburke alexjeffburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunesimonsen @coveralls @alexjeffburke