Relax the inline style validation in expectations #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think our current regex is anywhere near smart enough to recognize all valid style values. So I'm going to relax the validation.
|
I'm just going to merge this PR as I don't consider it controversial and it was me who introduced the check in the first place. |
sunesimonsen
force-pushed
the
ssimonsen/relax-style-validation
branch
from
3e5e6e2
to
94f5801
Compare
It seems like some default eslint configuration has changed when run with the latest dependencies that matches our ranges. I changed the tactic to make assigning to the global document in the test a bit more explicit.
sunesimonsen
changed the title
sunesimonsen
added a commit
that referenced
this pull request
Feb 20, 2019
…ation Relax the inline style validation in expectations
Pull Request Test Coverage Report for Build 1003
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.