Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mocha to version 5.2.0 #234

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Upgrade mocha to version 5.2.0 #234

merged 1 commit into from
Nov 16, 2018

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 31, 2018

We've upgraded a dependency and all tests pass. \o/

name version specification new version
mocha ^3.4.1 5.2.0

You should probably take a good look at this before merging this pull request, of course.

What changed?

✳️ mocha ( → 5.2.0) · Repo · Changelog

Release Notes

5.2.0

5.2.0 / 2018-05-18

🎉 Enhancements

🐛 Fixes

📖 Documentation

🔩 Other

5.1.1

5.1.1 / 2018-04-18

🐛 Fixes

5.1.0

5.1.0 / 2018-04-12

🎉 Enhancements

🐛 Fixes

📖 Documentation

🔩 Other

5.0.5

5.0.5 / 2018-03-22

Welcome @outsideris to the team!

🐛 Fixes

📖 Documentation

🔩 Other

5.0.4

5.0.4 / 2018-03-07

🐛 Fixes

  • #3265: Fixes regression in "watch" functionality introduced in v5.0.2 (@outsideris)

5.0.3

5.0.3 / 2018-03-06

This patch features a fix to address a potential "low severity" ReDoS vulnerability in the diff package (a dependency of Mocha).

🔒 Security Fixes

🔩 Other

5.0.2

5.0.2 / 2018-03-05

This release fixes a class of tests which report as false positives. Certain tests will now break, though they would have previously been reported as passing. Details below. Sorry for the inconvenience!

🐛 Fixes

  • #3226: Do not swallow errors that are thrown asynchronously from passing tests (@boneskull). Example:

    it('should actually fail, sorry!', function (done) {
  // passing assertion
  assert(true === true);

    // test complete & is marked as passing
    
done();
    

    // ...but something evil lurks within
    
setTimeout(() => {
    
throw new Error('chaos!');
    
}, 100);
    
});

    Previously to this version, Mocha would have silently swallowed the chaos! exception, and you wouldn't know. Well, now you know. Mocha cannot recover from this gracefully, so it will exit with a nonzero code.

    Maintainers of external reporters: If a test of this class is encountered, the Runner instance will emit the end event twice; you may need to change your reporter to use runner.once('end') intead of runner.on('end').

  • #3093: Fix stack trace reformatting problem (@outsideris)

:nut_and_bolt Other

5.0.1

5.0.1 / 2018-02-07

...your garden-variety patch release.

Special thanks to Wallaby.js for their continued support! ❤️

🐛 Fixes

📖 Documentation

🔩 Other

5.0.0

5.0.0 / 2018-01-17

Mocha starts off 2018 right by again dropping support for unmaintained rubbish.

Welcome @vkarpov15 to the team!

💥 Breaking Changes

  • #3148: Drop support for IE9 and IE10 (@Bamieh)
    Practically speaking, only code which consumes (through bundling or otherwise) the userland buffer module should be affected. However, Mocha will no longer test against these browsers, nor apply fixes for them.

🎉 Enhancements

🐛 Fixes

😎 Developer Experience

📖 Documentation

🔩 Other

4.1.0

4.1.0 / 2017-12-28

This is mainly a "housekeeping" release.

Welcome @Bamieh and @xxczaki to the team!

🐛: Fixes

  • #2661: progress reporter now accepts reporter options (@canoztokmak)
  • #3142: xit in bdd interface now properly returns its Test object (@Bamieh)
  • #3075: Diffs now computed eagerly to avoid misinformation when reported (@abrady0)
  • #2745: --help will now help you even if you have a mocha.opts (@Zarel)

🎉 Enhancements

  • #2514: The --no-diff flag will completely disable diff output (@CapacitorSet)
  • #3058: All "setters" in Mocha's API are now also "getters" if called without arguments (@makepanic)

📖 Documentation

🔩 Other

Not all release notes shown. View the full release notes

Commits

See the full diff on Github. The new version differs by 30 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Oct 31, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 906

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.177%
Totals Coverage Status
Change from base Build 896: 0.0%
Covered Lines: 520
Relevant Lines: 547
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 906

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.177%
Totals Coverage Status
Change from base Build 896: 0.0%
Covered Lines: 520
Relevant Lines: 547
💛 - Coveralls

@sunesimonsen sunesimonsen merged commit bf649df into master Nov 16, 2018
@sunesimonsen sunesimonsen deleted the depfu/update/npm/mocha-5.2.0 branch November 16, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @sunesimonsen