-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ignore bug #211
Fix: Ignore bug #211
Conversation
Pull Request Test Coverage Report for Build 788
💛 - Coveralls |
Interesting and good catch I'd say! Just for my understanding, does this come from text nodes being compared as plain strings and thus we end up comparing a text node to an empty object that fails in "to satisfy" when recursing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! I guess expect.it('to be a', 'DOMNode')
would also have worked, as all the unexpected-dom types except DOMNodeList
inherit from that. Still, there's certainly no harm in using any
, and "to be an any" sounds funny :)
Good point. I think that would actually be better and more precise. |
Released as unexpected-dom@4.6.2 |
Fixes: #212
Reproduces a bug where the user is trying to ignore a text node in to satisfy and fixes it.