Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why the background-image url is cut #291

Closed
sunesimonsen opened this issue Oct 7, 2019 · 3 comments · Fixed by #292
Closed

Investigate why the background-image url is cut #291

sunesimonsen opened this issue Oct 7, 2019 · 3 comments · Fixed by #292
Assignees
Labels

Comments

@sunesimonsen
Copy link
Member

Screenshot 2019-10-07 at 10 38 02

@sunesimonsen
Copy link
Member Author

Style prop is

<div style="background-image: url(https://www.example.com/one.png)" />

@papandreou
Copy link
Member

papandreou commented Oct 7, 2019

Must be happening here:

const tuple = rule.split(':').map(part => part.trim());

If there are 3 or more elements in tuple, it must re-join the rest by : to avoid throwing away //www.example.com/one.png).

@sunesimonsen
Copy link
Member Author

Thanks for finding this, this is me who have introduced this bug, so I'll also fix it again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants