feat: use orginal filename to generate document tite rather than the … #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiomarrocoli
force-pushed
the
feat/206/save-document-titles-as-original-filenames
branch
from
315ce84 to
56b002c
Compare
…sanitized one generated by the uploader
sergiomarrocoli
force-pushed
the
feat/206/save-document-titles-as-original-filenames
branch
from
56b002c to
43bf803
Compare
lucacug
deleted the
feat/206/save-document-titles-as-original-filenames
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/206
the file uploader sanitizes the filename, this is used to set the document title, which then needs to be corrected
this PR uses the original_filename before it is sanitized to set the document.
Testing:
upload some files with brackets in the filename. the Document title should match the original filename
the filename will still be modified