Feat/121/add non standard languages to autocomplete #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… common names can be queried
…n-standard-languages-to-autocomplete
sergiomarrocoli
commented
Aug 4, 2023
| @@ -0,0 +1,15 @@ | |||
| class AddAllCountriesToSpeciesAutomcomplete < ActiveRecord::Migration | |||
There was a problem hiding this comment.
change to languages
'remove_language_restrictions_from_autocomplete_view`
sergiomarrocoli
force-pushed
the
feat/121/add-non-standard-languages-to-autocomplete
branch
from
144f5df to
8ba4b24
Compare
sergiomarrocoli
changed the base branch from
feat/121/species-diacritic-search
to
develop
lucacug
deleted the
feat/121/add-non-standard-languages-to-autocomplete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unep-wcmc.codebasehq.com/projects/cites-support-maintenance/tickets/121
This is part of a quote, but I fixed it during debugging
Users are unable to search species with diacritics because we upcase the query term and search against upcased database records in an m view, and upcase doesn't work on diacritics. using mb_chars allows for upcasing of different languages and diacritics
another part of the quote that was an easy fix:
the view we use for common name searches previously filtered out any common names that weren't EN, ES, or FR language