Added sidebar for molecule #99
Conversation
Deploying with
|
| Latest commit: |
990d60d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ddaa2217.design-system.pages.dev |
stories/Organism/Sidebar/Sidebar.jsx
Outdated
| <div className='grid-x grid-margin-x'> | ||
| <div className='cell medium-4'> | ||
| <ul className='accordion-navbar' id="accordion"> | ||
| <span className='accordion-menu hide-for-large'>{label}</span> |
There was a problem hiding this comment.
@pallavikadam-srijan We can't have the span directly in ul and it should be wrapped in li
There was a problem hiding this comment.
@surbhi90 Done
stories/Organism/Sidebar/Sidebar.jsx
Outdated
| <div className='cell medium-4'> | ||
| <ul className='accordion-navbar' id="accordion"> | ||
| <span className='accordion-menu hide-for-large'>{label}</span> | ||
| <li className='accordion__item hide-for-small'> |
There was a problem hiding this comment.
@pallavikadam-srijan It should be accordion-navbar__item
There was a problem hiding this comment.
@surbhi90 Done
| } | ||
|
|
||
| ul.accordion-navbar > li:nth-child(2), | ||
| ul.accordion-navbar > li.accordion--active:nth-child(2) { |
There was a problem hiding this comment.
@pallavikadam-srijan Don't use tags with classname or id
There was a problem hiding this comment.
@surbhi90 Done
pallavikadam-srijan
force-pushed
the
UNDP-72/56-Molecule/Organism-5-sidebar
branch
from
eb4e8e2
to
91d6a9b
Compare
stories/assets/js/Faq_custom.js
Outdated
| export function SidebarMenu () { | ||
| $(".hide-for-large").click(function() { | ||
| $(".accordion-navbar").toggleClass("show"); | ||
| }); |
There was a problem hiding this comment.
@pallavikadam-srijan Please use the relevant id in JS
| </div> | ||
| </div> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
@pallavikadam-srijan Correct the structure
pallavikadam-srijan
force-pushed
the
UNDP-72/56-Molecule/Organism-5-sidebar
branch
from
91d6a9b
to
7ecc073
Compare
stories/Organism/Sidebar/Sidebar.jsx
Outdated
| return ( | ||
| <div className='grid-x grid-margin-x'> | ||
| <div className='cell medium-4 accordion-wrapper'> | ||
| <li className='accordion-menu' id='sidebar-menu'><span>{label}</span></li> |
There was a problem hiding this comment.
@pallavikadam-srijan can you use li outside of ul and it's class should be accordion__menu as per BEM
| } | ||
| } | ||
|
|
||
| .accordion-wrapper { |
There was a problem hiding this comment.
@pallavikadam-srijan you have also define accordion-wrapper on the top also so can you please put all styling in one place only and please follow the standard like accordion and then using child like &__menu
stories/Organism/Sidebar/Sidebar.jsx
Outdated
| <li className='accordion-navbar__item'> | ||
| <a href="#" className="accordion__heading">{headerText}</a> | ||
| <div class="accordion__panel"> | ||
| {data.map(function (item, index) { |
There was a problem hiding this comment.
@pallavikadam-srijan Where we are using sidebar molecule
pallavikadam-srijan
force-pushed
the
UNDP-72/56-Molecule/Organism-5-sidebar
branch
6 times, most recently
from
ce50d42
to
497c7d0
Compare
stories/Organism/Sidebar/Sidebar.jsx
Outdated
| return ( | ||
| <div className='grid-x grid-margin-x'> | ||
| <div className='cell medium-4 accordion-wrapper'> | ||
| <div className='accordion-navbar__menu' id='sidebar-menu'><span>{label}</span></div> |
There was a problem hiding this comment.
@pallavikadam-srijan can we just use the span and not in div
pallavikadam-srijan
force-pushed
the
UNDP-72/56-Molecule/Organism-5-sidebar
branch
3 times, most recently
from
30a1726
to
31784a7
Compare
pallavikadam-srijan
force-pushed
the
UNDP-72/56-Molecule/Organism-5-sidebar
branch
from
31784a7
to
990d60d
Compare
Created sidebar for a molecule.
Made change on ImageCard.stories.mdx file for update the spelling - Image reveal card instead of Image revel card