UND-38-navigation-footer #74
Conversation
Deploying with
|
| Latest commit: |
70c5fd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a763caa.design-system.pages.dev |
|
|
||
| export const FooterLists = ({ type, headerText, text, style }) => { | ||
| const ListTag = `${type}`; | ||
| useEffect(() => { |
There was a problem hiding this comment.
@harishkumar-srijan remove useeffect hook if we are not using it
| } | ||
| a { | ||
| font-size: 16px; | ||
| line-height: 22px; |
There was a problem hiding this comment.
@harishkumar-srijan can we use font size in rem and use the varibles
There was a problem hiding this comment.
Done use the variable and variable is converted in rem done by shubam already.
harishkumar-srijan
force-pushed
the
UND-38-navigation-footer
branch
from
c49b8e6
to
5c9cdc3
Compare
| <li><a href="#">{text}</a></li> | ||
| <li><a href="#">{text2}</a></li> | ||
| <li><a href="#">{text3}</a></li> | ||
| <li><a href="#">{text4}</a></li> |
There was a problem hiding this comment.
@harishkumar-srijan can we create it as array and use map function for this
| <li><a href="#">{text3}</a></li> | ||
| <li><a href="#">{text4}</a></li> | ||
| <li><a href="#">{text2}</a></li> | ||
| </ul> |
There was a problem hiding this comment.
@harishkumar-srijan can we create it as array and use map function for this
| <a href="#" className="linkedIn"></a> | ||
| <a href="#" className="instragram"></a> | ||
| <a href="#" className="twitter"></a> | ||
| <a href="#" className="youtube"></a> |
There was a problem hiding this comment.
@harishkumar-srijan it is semantically wrong...please use li tag inside the ul tag
| <Link label={text} /> | ||
| <Link label={text} /> | ||
| <Link label={text} /> | ||
| <Link label={text} /> |
There was a problem hiding this comment.
@harishkumar-srijan can we create it as array and use map function for this
harishkumar-srijan
force-pushed
the
UND-38-navigation-footer
branch
from
5c9cdc3
to
70c5fd8
Compare
navigation footer