Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cards atoms created #38

Merged
merged 1 commit into from
Sep 27, 2021
Merged

cards atoms created #38

merged 1 commit into from
Sep 27, 2021

Conversation

harishkumar-srijan
Copy link
Contributor

cards atoms created

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 27, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bbab0c2
Status: ✅  Deploy successful!
Preview URL: https://b8a29442.design-system.pages.dev

View logs

Copy link
Contributor

@surbhi90 surbhi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

}
}
}
/* publication thumbnail end*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harishkumar-srijan Please check if we have these spacing variables and if we can create the variables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harishkumar-srijan Please also check the indentation

Copy link
Contributor

@surbhi90 surbhi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surbhi90 surbhi90 merged commit 7c81b73 into develop Sep 27, 2021
@kuldev kuldev deleted the UND-33-Atoms-cards-new branch February 25, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants