modal light box blank #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
33c2f73
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c425562.design-system.pages.dev |
surbhi90
suggested changes
Nov 1, 2021
| import React from "react"; | ||
| import "./lightbox.scss"; | ||
| export const Lightbox = ({}) => ( | ||
| <> |
There was a problem hiding this comment.
@harishkumar-srijan I don't think we need this fragment
| .modal-content { | ||
| width: 100%; | ||
| max-width: 837px; | ||
| height: 492px; |
There was a problem hiding this comment.
@harishkumar-srijan It should be in vh or in % otherwise it won't be consistent in all the devices
harishkumar-srijan
force-pushed
the
UND-209-Modal-Lightbox
branch
from
db3877f
to
33c2f73
Compare
surbhi90
reviewed
Nov 1, 2021
| import { Meta, Story, canvas } from '@storybook/addon-docs'; | ||
| import { Lightbox } from './Lightbox'; | ||
|
|
||
| <Meta title="Molecules/Blocks/Lightbox" /> |
There was a problem hiding this comment.
@harishkumar-srijan Component is not placed as per the tree structure...still merging the PR but please correct this one
surbhi90
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modal light box blank