Added language switcher #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallavikadam-srijan
force-pushed
the
UNDP-155-Molecule-language-switcher
branch
from
c05f601
to
31f9e5e
Compare
Deploying with
|
| Latest commit: |
c5acb26
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://46d55f3b.design-system.pages.dev |
pallavikadam-srijan
force-pushed
the
UNDP-155-Molecule-language-switcher
branch
3 times, most recently
from
a269c88
to
140625f
Compare
surbhi90
suggested changes
Oct 25, 2021
| transform: scaleX(-1); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@pallavikadam-srijan why we are using the nesting in scss...can't we keep the dropdown-btn outside of dropdown-language
pallavikadam-srijan
force-pushed
the
UNDP-155-Molecule-language-switcher
branch
3 times, most recently
from
76a3084
to
a852317
Compare
surbhi90
suggested changes
Oct 25, 2021
| display: inline-block; | ||
| position: relative; | ||
|
|
||
| .dropdown-btn { |
There was a problem hiding this comment.
@pallavikadam-srijan can you also please keep this dropdown-btn outside of dropdown-language
pallavikadam-srijan
force-pushed
the
UNDP-155-Molecule-language-switcher
branch
from
a852317
to
c5acb26
Compare
surbhi90
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a language switcher.