Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default link doesn't display underline #887

Closed
theadamparker opened this issue Feb 24, 2022 · 5 comments
Closed

Default link doesn't display underline #887

theadamparker opened this issue Feb 24, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@theadamparker
Copy link
Contributor

Currently the default link shows no visual distinction from plain text. It should have a red underline.

@theadamparker theadamparker added the bug Something isn't working label Feb 24, 2022
@theadamparker
Copy link
Contributor Author

Related to #888

@devjgigas devjgigas self-assigned this Mar 31, 2022
@Jura
Copy link
Member

Jura commented Mar 31, 2022

@theadamparker , @devjgigas , @Malakeldardiri , I think we should move default hyperlink treatment from Atoms section to generic typography. In my view default setting for tag should be part of our baseline stylesheet and not optional plugin as it is done right now. What do you think? I'd also keep it animated by default, not just underlined. Please share you thoughts.

@Jura
Copy link
Member

Jura commented Mar 31, 2022

To illustrate the point, hyperlink tag styling is defined in https://github.com/undp/design-system/blob/master/stories/Atom/Typography/Links/link.scss , but I'm suggesting to move it to https://github.com/undp/design-system/blob/master/stories/assets/scss/_typography.scss to make sure it is the part of base stylesheet. We will keep story definition intact, just relocate the rule

@theadamparker
Copy link
Contributor Author

@Jura I agree that it should be moved to generic typography and animated by default.

@Jura
Copy link
Member

Jura commented Mar 31, 2022

@devjgigas , can you please merge link.scss style definitions to _typography.scss, somewhere after hr definition? You might also want to remove .animated-link class definition and merge its contain with default a tag treatment.
Link Atom Story won't need any specific .scss file, you can delete it and update .jsx template accordingly. Please also update documentation as we won't use that class anymore

Jura added a commit that referenced this issue Apr 5, 2022
#887:Added red underline to default link
@Jura Jura closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants