-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default link doesn't display underline #887
Comments
Related to #888 |
@theadamparker , @devjgigas , @Malakeldardiri , I think we should move default hyperlink treatment from Atoms section to generic typography. In my view default setting for tag should be part of our baseline stylesheet and not optional plugin as it is done right now. What do you think? I'd also keep it animated by default, not just underlined. Please share you thoughts. |
To illustrate the point, hyperlink tag styling is defined in https://github.com/undp/design-system/blob/master/stories/Atom/Typography/Links/link.scss , but I'm suggesting to move it to https://github.com/undp/design-system/blob/master/stories/assets/scss/_typography.scss to make sure it is the part of base stylesheet. We will keep story definition intact, just relocate the rule |
@Jura I agree that it should be moved to generic typography and animated by default. |
@devjgigas , can you please merge link.scss style definitions to _typography.scss, somewhere after hr definition? You might also want to remove |
Currently the default link shows no visual distinction from plain text. It should have a red underline.
The text was updated successfully, but these errors were encountered: