Skip to content

[UNDERTOW-2625] Guard against bad characters in isValid*Character #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2625] Guard against bad characters in isValid*Character #1837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/src/main/java/io/undertow/server/Connectors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,11 +664,19 @@ public static void verifyToken(HttpString header) {
* Returns true if the token character is valid according to rfc7230
*/
public static boolean isValidTokenCharacter(byte c) {
return ALLOWED_TOKEN_CHARACTERS[c];
if (c < 0 || c > ALLOWED_TOKEN_CHARACTERS.length - 1) {
return false;
} else {
return ALLOWED_TOKEN_CHARACTERS[c];
}
}

public static boolean isValidSchemeCharacter(byte c) {
return ALLOWED_SCHEME_CHARACTERS[c];
if (c < 0 || c > ALLOWED_SCHEME_CHARACTERS.length - 1) {
return false;
} else {
return ALLOWED_SCHEME_CHARACTERS[c];
}
}


Expand Down