Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2010] Add invalidate() to caching manager #1487

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2010] Add invalidate() to caching manager #1487

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Jun 7, 2023

@fl4via fl4via added the bug fix Contains bug fix(es) label Jun 7, 2023
@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) waiting peer review PRs that edit core classes might require an extra review and removed bug fix Contains bug fix(es) labels Oct 21, 2024
ropalka
ropalka requested changes Oct 22, 2024
View reviewed changes
core/src/main/java/io/undertow/server/handlers/cache/LRUCache.java Outdated
@@ -172,6 +172,18 @@ public void clear() {
accessQueue.clear();
}

public Set<K> keys(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a keySet() method defined already serving the same purpose.
Further more it properly makes returned keys read only.
We should remove this keys() method.

core/src/main/java/io/undertow/server/handlers/resource/CachingResourceManager.java Outdated Show resolved Hide resolved
core/src/main/java/io/undertow/server/handlers/resource/CachingResourceManager.java Outdated Show resolved Hide resolved
core/src/main/java/io/undertow/server/handlers/resource/CachingResourceManager.java Show resolved Hide resolved
@baranowb baranowb requested a review from ropalka November 26, 2024 10:12
ropalka
ropalka approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @baranowb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@jasondlee jasondlee Awaiting requested review from jasondlee

@fl4via fl4via Awaiting requested review from fl4via

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baranowb @ropalka @fl4via