Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2254] Included the HttpServerExchange in the HostSelector. #1464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2254] Included the HttpServerExchange in the HostSelector. #1464

wants to merge 1 commit into from

Conversation

jeham
Copy link

@jeham jeham commented Apr 12, 2023

This allows for advanced routing based on eg. header values or attributes.

@jeham
Copy link
Author

jeham commented Apr 20, 2023

@fl4via New PR here, thanks!

@fl4via fl4via added the new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) label Apr 23, 2023
@fl4via fl4via changed the title Included the HttpServerExchange in the HostSelector. [UNDERTOW-2254] Included the HttpServerExchange in the HostSelector. Apr 23, 2023
@fl4via fl4via added bug fix Contains bug fix(es) enhancement Enhances existing behaviour or code and removed bug fix Contains bug fix(es) labels Apr 23, 2023
@fl4via
Copy link
Member

fl4via commented Apr 23, 2023

Thanks @jeham ! Because you are keeping the old signature, I'm considering adding this to 2.3.6.Final, and then we remove the old one for 2.4.0.Final.

fl4via
fl4via requested changes Apr 23, 2023
View reviewed changes
Copy link
Member

@fl4via fl4via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeham Can you please amend the commit and add [UNDERTOW-2254] to the beginning of the commit message?

@fl4via fl4via added the waiting PR update Awaiting PR update(s) from contributor before merging label Apr 23, 2023
@jeham
[UNDERTOW-2254] Included the HttpServerExchange in the HostSelector.
c2eebe5 
 This allows for advanced routing based on eg. header values or attributes.
@jeham
Copy link
Author

jeham commented May 2, 2023

@jeham Can you please amend the commit and add [UNDERTOW-2254] to the beginning of the commit message?

Done!

@jeham jeham requested a review from fl4via May 8, 2023 19:16
@jeham
Copy link
Author

jeham commented May 30, 2023

Is this up for 2.3.7 now, @fl4via ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl4via fl4via Awaiting requested review from fl4via

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) waiting PR update Awaiting PR update(s) from contributor before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeham @fl4via