UNDERTOW-2194 - improve cookie parsing so its aligned with spec without 3rd part deps. #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baranowb
force-pushed
the
UNDERTOW-2194_sac
branch
from
34a843d to
4815694
Compare
fl4via
approved these changes
Feb 2, 2023
fl4via
added
the
new feature/API change
baranowb
force-pushed
the
UNDERTOW-2194_sac
branch
from
4815694 to
82ecab8
Compare
ropalka
requested changes
Jul 30, 2024
core/src/main/java/io/undertow/server/MultiValueHashListStorage.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/undertow/server/MultiValueHashListStorage.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/undertow/server/MultiValueHashListStorage.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/undertow/server/MultiValueHashListStorage.java
Outdated
Show resolved
Hide resolved
| storage.clear(); | ||
| } | ||
|
|
||
| private class DefaultIterator<V> implements Iterator<V> { |
There was a problem hiding this comment.
DefaultIterator should have ideally both "static final" classifiers. With "static" classifier DefaultIterator class could be shared among all MultiValueHashListStorage object instances. Without "static" classifier new DefaultIterator class is created per MultiValueHashListStorage instances. This change will result in improvements to shared memory AKA "method area" .
baranowb
force-pushed
the
UNDERTOW-2194_sac
branch
from
82ecab8 to
6249710
Compare
baranowb
added
the
under verification
|
Ive set "under veirfication" in light of crossreviewing with another RFE. Details in doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2194
This will replace: #1408