Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNDERTOW-1874 ProxyForwardedTestCase and ProxyXForwardedTestCase should check results with DefaultServer.getDefaultServerAddress() instead of Socket.getLocalAddress() #1078

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UNDERTOW-1874 ProxyForwardedTestCase and ProxyXForwardedTestCase should check results with DefaultServer.getDefaultServerAddress() instead of Socket.getLocalAddress() #1078

wants to merge 1 commit into from

Conversation

msfm
Copy link
Contributor

@msfm msfm commented Mar 30, 2021 •
edited
Loading

@msfm
Copy link
Contributor Author

msfm commented Mar 30, 2021 •
edited
Loading

Ah, wait... I've just noticed that creating a Socket is not required for this unit test. I think DefaultServer.getDefaultServerAddress() can be used instead. I'll double-check and update this PR soon.

-> Done. I've pushed a new fix.

@msfm
UNDERTOW-1874 ProxyForwardedTestCase and ProxyXForwardedTestCase shou…
12090de 
…ld check results with DefaultServer.getDefaultServerAddress() instead of Socket.getLocalAddress()
@msfm msfm force-pushed the master_UNDERTOW-1874 branch from a5bf35c to 12090de Compare March 30, 2021 17:14
@msfm msfm changed the title ProxyForwardedTestCase and ProxyXForwardedTestCase should check with … UNDERTOW-1874 ProxyForwardedTestCase and ProxyXForwardedTestCase should check results with DefaultServer.getDefaultServerAddress() instead of Socket.getLocalAddress() Mar 30, 2021
@fl4via fl4via added bug fix Contains bug fix(es) next release This PR will be merged before next release or has already been merged (for payload double check) labels Apr 8, 2021
@fl4via fl4via added the failed CI Introduced new regession(s) during CI check label Apr 8, 2021
@fl4via
Copy link
Member

fl4via commented Apr 8, 2021

@msfm ProxyForwardedTestCase is failing in Windows with this change

@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Jul 20, 2021
@baranowb baranowb self-requested a review November 26, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baranowb baranowb baranowb approved these changes

@fl4via fl4via fl4via approved these changes

@ropalka ropalka ropalka approved these changes

Assignees
No one assigned
Labels
bug fix Contains bug fix(es) failed CI Introduced new regession(s) during CI check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msfm @fl4via @ropalka @baranowb