Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of fixes to linting, wandb api usage, readme #207

Closed
wants to merge 23 commits into from
Closed

Integration of fixes to linting, wandb api usage, readme #207

wants to merge 23 commits into from

Conversation

mivanit
Copy link
Member

@mivanit mivanit commented Jan 28, 2024 •
edited
Loading

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mivanit mivanit changed the title Integration of some fixes Integration of fixes to linting, wandb api usage, readme Jan 28, 2024
@mivanit mivanit added bug Something isn't working documentation Improvements or additions to documentation code-quality code quality improvement wandb anything related to weights & biases integration labels Jan 28, 2024
@mivanit
reverting logger changes to training.py
8ee589d 
originally introduced in commit [c39070a](c39070a)

this is being removed since we still want to pass a `WandbLogger` object around,
but instead modify the `WandbLogger` to have the ability to do some logging locally-only
@mivanit
wip, junk, needs review!
bdd9034
@mivanit mivanit mentioned this pull request Jul 26, 2024
Closed
@mivanit
Copy link
Member Author

mivanit commented Jul 26, 2024

closing, since having half-baked local logging alternatives is not the move. might eventually migrate to https://pypi.org/project/trnbl/ for switching between loggers

@mivanit mivanit closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working code-quality code quality improvement documentation Improvements or additions to documentation wandb anything related to weights & biases integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop integration tests from logging to wandb
2 participants
@mivanit @naveenarun