Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get mypy passing and add PR gate #18

Closed
rusheb opened this issue Feb 16, 2023 · 4 comments
Closed

Get mypy passing and add PR gate #18

rusheb opened this issue Feb 16, 2023 · 4 comments
Assignees
@cmathw
Labels
good first issue Good for newcomers

Comments

@rusheb
Copy link
Collaborator

rusheb commented Feb 16, 2023

No description provided.

@rusheb
Copy link
Collaborator Author

rusheb commented Feb 16, 2023

Also blocked by #10

@valedan
Copy link
Contributor

valedan commented Mar 6, 2023

"Add PR gate" is blocked by #59 and #60, but I think we can get started right away on getting mypy passing!

@valedan valedan added the good first issue Good for newcomers label Mar 6, 2023
@rusheb
Copy link
Collaborator Author

rusheb commented Mar 7, 2023

"Add PR gate" is blocked by #59 and #60, but I think we can get started right away on getting mypy passing!

We can add the PR gates now, they just won't be enforced until the repo is made public.

@rusheb rusheb mentioned this issue Mar 11, 2023
Merged
@cmathw cmathw self-assigned this Mar 24, 2023
@rusheb rusheb mentioned this issue Mar 27, 2023
Merged
@traeuker traeuker closed this as completed Jul 5, 2023
@traeuker
Copy link
Member

traeuker commented Jul 5, 2023 •
edited
Loading

Seems to be not a huge priority right now - @mivanit feel free to reopen if you think otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmathw cmathw

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@valedan @rusheb @traeuker @cmathw