Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment does not work from forked repository #14

Closed
undergroundwires opened this issue Jun 29, 2020 · 1 comment
Closed

Deployment does not work from forked repository #14

undergroundwires opened this issue Jun 29, 2020 · 1 comment

Comments

@undergroundwires
Copy link
Owner

The problem is that deploy.yaml depends on a secret that cannot be read when it's triggered by PR.

When you create a pull request from forked repository to base repository, the workflow will be triggered on base repository. (documentation)
It’s by designed that encrypted secrets are not passed to the runner when a workflow is triggered from a forked repository. (documentation)

However we need the secret there otherwise creating release does not trigger AWS deployment (as documented) here.

Need to solve that 🤔

@undergroundwires
Copy link
Owner Author

Maintainer needs to push tags manually to get this working. Updated documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant