Skip to content

Commit

Permalink
Fix Microsoft Defender alert for uninstaller #114
Browse files Browse the repository at this point in the history
Microsoft Defender considers the uninstaller virus. It's a
false-psoitive caused by `electron-builder` used to build NSIS package.

This commit solves the issue by explicitly adding `electron-builder` as
dependency. This way, `vue-cli-plugin-electron-builder` always resolves
to the desired version. Now the version used for `electron-builder` is
more controlled. New uninstaller generated by latest specified patch
does not trigger an alert, which solves the false-positive issue.

See also:
  - electron-userland/electron-builder#4793,
  - electron-userland/electron-builder#4878.
  • Loading branch information
undergroundwires committed Feb 27, 2022
1 parent eeb1d5b commit 112e79a
Show file tree
Hide file tree
Showing 2 changed files with 220 additions and 98 deletions.
Loading

0 comments on commit 112e79a

Please sign in to comment.