fix(compiler-core): fix vOn compiled code (vuejs#572)

underfin · Jan 3, 2020 · ee2cc15 · ee2cc15
1 parent 7770d6d
commit ee2cc15
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/compiler-core/__tests__/transforms/__snapshots__/hoistStatic.spec.ts.snap b/packages/compiler-core/__tests__/transforms/__snapshots__/hoistStatic.spec.ts.snap
@@ -216,7 +216,7 @@ export function render() {
   return (openBlock(), createBlock(\\"div\\", null, [
     createVNode(\\"div\\", null, [
       createVNode(\\"div\\", {
-        onClick: _cache[1] || (_cache[1] = $event => (_ctx.foo($event)))
+        onClick: _cache[1] || (_cache[1] = $event => {_ctx.foo($event)})
       })
     ])
   ]))

diff --git a/packages/compiler-core/__tests__/transforms/vOn.spec.ts b/packages/compiler-core/__tests__/transforms/vOn.spec.ts
@@ -135,7 +135,7 @@ describe('compiler: transform v-on', () => {
       key: { content: `onClick` },
       value: {
         type: NodeTypes.COMPOUND_EXPRESSION,
-        children: [`$event => (`, { content: `i++` }, `)`]
+        children: [`$event => {`, { content: `i++` }, `}`]
       }
     })
   })
@@ -151,13 +151,13 @@ describe('compiler: transform v-on', () => {
       value: {
         type: NodeTypes.COMPOUND_EXPRESSION,
         children: [
-          `$event => (`,
+          `$event => {`,
           { content: `_ctx.foo` },
           `(`,
           // should NOT prefix $event
           { content: `$event` },
           `)`,
-          `)`
+          `}`
         ]
       }
     })
@@ -284,7 +284,7 @@ describe('compiler: transform v-on', () => {
         index: 1,
         value: {
           type: NodeTypes.COMPOUND_EXPRESSION,
-          children: [`$event => (`, { content: `_ctx.foo($event)` }, `)`]
+          children: [`$event => {`, { content: `_ctx.foo($event)` }, `}`]
         }
       })
     })
@@ -322,7 +322,7 @@ describe('compiler: transform v-on', () => {
         index: 1,
         value: {
           type: NodeTypes.COMPOUND_EXPRESSION,
-          children: [`$event => (`, { content: `_ctx.foo` }, `++`, `)`]
+          children: [`$event => {`, { content: `_ctx.foo` }, `++`, `}`]
         }
       })
     })

diff --git a/packages/compiler-core/src/transforms/vOn.ts b/packages/compiler-core/src/transforms/vOn.ts
@@ -85,9 +85,9 @@ export const transformOn: DirectiveTransform = (
     if (isInlineStatement || (isCacheable && isMemberExp)) {
       // wrap inline statement in a function expression
       exp = createCompoundExpression([
-        `$event => (`,
+        `$event => {`,
         ...(exp.type === NodeTypes.SIMPLE_EXPRESSION ? [exp] : exp.children),
-        `)`
+        `}`
       ])
     }
   }