-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bunch of Tiny Fixes and Enhancements #41
Conversation
This also declares some hidden dependencies for the underlying connection protocols, but note that they are normally reliant on system-packaged versions, which is a bit less than optimal.
…nd line Also addresses a crash in led demo where parameters x and y were not provided to an empty lamba that was passed in.
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
===========================================
+ Coverage 45.24% 75.49% +30.24%
===========================================
Files 37 17 -20
Lines 3421 2057 -1364
===========================================
+ Hits 1548 1553 +5
+ Misses 1873 504 -1369
Continue to review full report at Codecov.
|
pylgbst/messages.py
Outdated
@@ -173,7 +173,7 @@ def bytes(self): | |||
return super(MsgHubAction, self).bytes() | |||
|
|||
def is_reply(self, msg): | |||
assert isinstance(msg, MsgHubAction) | |||
assert isinstance(msg, MsgHubAction), type(msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to add some message to it, like 'Unexpected type message type: %s'
. Let's do it good if we got to improving it :)
@@ -14,18 +15,24 @@ | |||
|
|||
queue = queue # just to use it | |||
|
|||
def check_unpack(seq, index, pattern, size): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code needs some formatting to comply to PEP-9.
setup.py
Outdated
@@ -1,4 +1,5 @@ | |||
from distutils.core import setup | |||
#from distutils.core import setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't comment, just delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, if you're okay with the change I'll commit to it.
setup.py
Outdated
@@ -8,9 +9,10 @@ | |||
packages=['pylgbst', "pylgbst.comms"], | |||
requires=[], | |||
extras_require={ | |||
'gatt': ["gatt"], | |||
# Note that dbus and gi are normally system packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do regular formatting, like standards require
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't realise you had a formatting spec. I don't see one in the repository, so I'm assuming black, though that seems to be producing rather large diffs on the modules to which I'm applying it.
Thanks for contributing. I've put some comments, please address them. |
Hey there,
Thanks for all the work on the package. We've just spent an hour or two here getting everything connected and working on Linux/Ubuntu/Kubuntu 19.10 on a new Boost Vernie and thought we'd kick back the changes we made to get the demo running here.
Feel free to cherry pick individual commits if you'd rather skip some of the changes.
Take care,
Mike