fix: Add newline before pre codeblock start #462
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is additional text before the 'pre' code block begins :
This results in a malformed generated markdown:
This just adds a newline before the start of the code block, should be fairly inconsequential.
New result:
There's another issue with handling whitespaces that are defined like:
<span class="w"> </span>
, seems like the parser is sending the entire content tohandle_data
if the code block is something likethe html will be parsed with
handle_data("pythonmain.py")
, so the whitespace is not preserved. That seems like it would require updating the underlying HTMLParser logic or overriding it so I didn't try to address it myself. Just wanted to raise it in case it wasn't known.example: