fix: Allow local embeddings by removing OpenAI fallback (#1658)#1717
Merged
unclecode merged 1 commit intounclecode:developfrom Feb 1, 2026
Merged
Conversation
…trategy Fixes unclecode#1658 The `_get_embedding_llm_config_dict` method was returning a fallback OpenAI config when `embedding_llm_config` was None, which prevented the use of local sentence-transformers embeddings. Changed the method to: - Return None when no embedding config is provided - Update return type from Dict to Optional[Dict] - Update docstring to clarify the behavior This allows `get_text_embeddings` utility to correctly switch to the local sentence-transformers implementation when no LLM config is provided. Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Merged into develop — thanks for fixing the embeddings fallback. Will be in the next release, and we'll add you to CONTRIBUTORS.md. |
6 tasks
unclecode
added a commit
that referenced
this pull request
Feb 1, 2026
- PR #1714: Replace tf-playwright-stealth with playwright-stealth - PR #1721: Respect <base> tag in html2text for relative links - PR #1719: Include GoogleSearchCrawler script.js in package data - PR #1717: Allow local embeddings by removing OpenAI fallback - Fix: Extract <base href> from raw HTML before head gets stripped - Close duplicates: #1703, #1698, #1697, #1710, #1720 - Update CONTRIBUTORS.md and PR-TODOLIST.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Fixes #1658
📝 Description
The
_get_embedding_llm_config_dictmethod inEmbeddingStrategywas returning a fallback OpenAI config whenembedding_llm_configwas None. This prevented users from using localsentence-transformersembeddings, as theget_text_embeddingsutility never sawNoneand always used remote embeddings.🔧 Changes
crawl4ai/adaptive_crawler.py:
DicttoOptional[Dict]Nonewhen no config is provided✅ Before
✅ After
🎯 Impact
Users can now use local embeddings by configuring
AdaptiveCrawlerwithoutembedding_llm_config:Co-Authored-By: Claude noreply@anthropic.com