[RFR] Improved SCSS code consistency #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ | |||
| filter: contrast(1.1) brightness(1.1) saturate(1.3); | |||
|
|
|||
| &:after{ | |||
| background: rgba(243, 106, 188, .3); | |||
| background: rgba(243, 106, 188, 0.3); | |||
There was a problem hiding this comment.
I generally omit leading 0's as a rule 😄
There was a problem hiding this comment.
Oh. You did not do it everywhere, so I just assumed it was better to add it.
My 2 cents on this is that it is the minifier’s role to shorten your code, not yours. :)
There was a problem hiding this comment.
Ahh! I intended to remove them if I have any leading 0's. Thank you for the changes! If you take the leading 0's back out, I'd be happy to merge! 👍
Merged
|
Done. |
|
Perfect :) Please pull changes so it's mergable |
una
added a commit
that referenced
this pull request
Nov 19, 2015
[RFR] Improved SCSS code consistency
una
pushed a commit
that referenced
this pull request
Nov 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cheers. :)