unidecode vs text_unidecode import resolution order
#126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AS is `text_unidecode` is install_requires it is always present in the python environment, it makes sense to try import optinal dependency `unidecode` first, and only then fallback to `text_unidecode`.
Owner
|
Excellent. Thank you. |
Owner
|
Version 8.0.0 is pushed. Thx |
Contributor
Author
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the code is now
unidecodelibrary is just getting ignored.text_unidecodeis install_requires and is always present in the python environment, so it makes sense to try importing the optional dependencyunidecodefirst and only then fallback totext_unidecode.