Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: billing system overhaul #751

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat: billing system overhaul #751

merged 1 commit into from
Aug 28, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Aug 27, 2024 •
edited
Loading

What does this PR do?

Fixes ENG-111
Fixes ENG-126
Fixes ENG-116
Fixes #476

Changes

  • Subscribing to Plans are now done in a embedded Checkout modal without having user to leave UnInbox.
  • Handle subscription creation, updates and deletes properly
  • Update subscription details when a user deletes their account
  • Create a migration script for syncing stripe with orgBiliing database
  • Change the metadata to only store orgId and totalusers, as everything else should be determined by stripe price objects

Important

  • We need a new Env variable with name BILLING_STRIPE_PUBLISHABLE_KEY to render the stripe modal

@BlankParticle Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite Graphite

@BlankParticle BlankParticle marked this pull request as ready for review August 27, 2024 18:14
@BlankParticle BlankParticle force-pushed the blank/feat/billing-system-overhaul branch from e123cb2 to 48984fb Compare August 27, 2024 18:20
@BlankParticle BlankParticle requested review from a team and removed request for McPizza0 August 28, 2024 17:09
@BlankParticle BlankParticle force-pushed the blank/feat/billing-system-overhaul branch from 48984fb to 59c7698 Compare August 28, 2024 17:43
@BlankParticle Graphite App
Copy link
Member Author

BlankParticle commented Aug 28, 2024 •
edited
Loading

Merge activity

  • Aug 28, 1:44 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 28, 1:45 PM EDT: @BlankParticle merged this pull request with Graphite.

@BlankParticle BlankParticle merged commit 889302b into main Aug 28, 2024
5 checks passed
@BlankParticle BlankParticle deleted the blank/feat/billing-system-overhaul branch August 28, 2024 17:57
BlankParticle added a commit that referenced this pull request Aug 28, 2024
@BlankParticle
Revert "feat: billing system overhaul (#751)"
8f747c6
@BlankParticle BlankParticle restored the blank/feat/billing-system-overhaul branch August 28, 2024 18:25
@BlankParticle BlankParticle deleted the blank/feat/billing-system-overhaul branch August 28, 2024 18:28
BlankParticle added a commit that referenced this pull request Aug 28, 2024
@BlankParticle
feat: billing system overhaul (#751)
9b155c0
@BlankParticle BlankParticle mentioned this pull request Aug 28, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McPizza0 McPizza0 McPizza0 approved these changes

Assignees

@BlankParticle BlankParticle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

billing: fail with discount
2 participants
@BlankParticle @McPizza0