Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update correct space when creating a convo #744

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Aug 26, 2024

What does this PR do?

Updates the correct space cache when creating a new convo
Fixes ENG-164

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

BlankParticle commented Aug 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite Graphite

@BlankParticle BlankParticle marked this pull request as ready for review August 26, 2024 12:13
@BlankParticle BlankParticle force-pushed the blank/fix/update-correct-space branch 2 times, most recently from 0254b5c to c2b5004 Compare August 26, 2024 12:19
@BlankParticle BlankParticle changed the base branch from blank/feat/fix-external-smtp to graphite-base/744 August 26, 2024 12:35
@BlankParticle BlankParticle force-pushed the blank/fix/update-correct-space branch from c2b5004 to eeb2d86 Compare August 26, 2024 12:36
@BlankParticle BlankParticle changed the base branch from graphite-base/744 to main August 26, 2024 12:36
@BlankParticle BlankParticle force-pushed the blank/fix/update-correct-space branch from eeb2d86 to f53dbaa Compare August 26, 2024 12:36
@BlankParticle BlankParticle merged commit 2dde482 into main Aug 26, 2024
4 checks passed
Copy link
Member Author

Merge activity

@BlankParticle BlankParticle deleted the blank/fix/update-correct-space branch August 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants