Skip to content

feat(web): Convo View #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2024
Merged

feat(web): Convo View #485

merged 1 commit into from
Jun 19, 2024

Conversation

OmarMcAdam
Copy link
Member

@OmarMcAdam OmarMcAdam commented May 29, 2024 •
edited
Loading

Adds the convo view panel according to new designs

image.png

@OmarMcAdam Graphite App
Copy link
Member Author

OmarMcAdam commented May 29, 2024 •
edited by BlankParticle
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @McPizza0 and the rest of your teammates on Graphite Graphite

@OmarMcAdam OmarMcAdam force-pushed the feat_web_Convo_View branch from eb8d3c3 to c9761ec Compare June 3, 2024 15:51
@OmarMcAdam OmarMcAdam force-pushed the feat_web_Convo_View branch from c9761ec to ffee434 Compare June 17, 2024 14:55
@BlankParticle BlankParticle mentioned this pull request Jun 17, 2024
Merged
16 tasks
@OmarMcAdam OmarMcAdam force-pushed the feat_web_Convo_View branch 2 times, most recently from 16230c8 to 06fced4 Compare June 17, 2024 22:26
@OmarMcAdam OmarMcAdam requested a review from BlankParticle June 17, 2024 22:27
@OmarMcAdam OmarMcAdam marked this pull request as ready for review June 17, 2024 22:27
@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 17, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (06/17/24)

1 assignee was added to this PR based on Rahul Mishra's automation.

@BlankParticle
Copy link
Member

image
There is extra whitespace in the convos list as the grid is divided in 3 cols and convos list occupies 1/3 of that, but the convos list has a max width which causes the issue

@BlankParticle
Copy link
Member

image
while having more messages the send sections goes out of the screen

BlankParticle
BlankParticle requested changes Jun 18, 2024
View reviewed changes
This was referenced Jun 18, 2024
Merged
Merged
@OmarMcAdam OmarMcAdam force-pushed the feat_web_Convo_View branch from 06fced4 to 83250c7 Compare June 19, 2024 11:12
@OmarMcAdam Graphite App
Copy link
Member Author

@BlankParticle updated

@OmarMcAdam Graphite App
Copy link
Member Author

image
while having more messages the send sections goes out of the screen

ill need to fix later

@OmarMcAdam OmarMcAdam requested a review from BlankParticle June 19, 2024 11:22
BlankParticle
BlankParticle approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@BlankParticle BlankParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message UI overflow issues aside, LGTM

@OmarMcAdam OmarMcAdam merged commit c0f41f6 into main Jun 19, 2024
5 checks passed
@OmarMcAdam Graphite App
Copy link
Member Author

Merge activity

  • Jun 19, 7:44 AM EDT: @McPizza0 merged this pull request with Graphite.

@BlankParticle BlankParticle deleted the feat_web_Convo_View branch June 20, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlankParticle BlankParticle BlankParticle approved these changes

Assignees

@OmarMcAdam OmarMcAdam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarMcAdam @BlankParticle