fix: drop languageOptions config from flat/recommended
#368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent showing linting errors on code that relies on ECMAScript features implemented after 2018. If a user wants to limit the ECMAScript version to use, it should set that on his config.
🦋 Changeset detectedLatest commit: acdf7c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe Changes
Assessment against linked issues
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 049554a in 31 seconds. Click for details.
- Reviewed
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/config/flat/recommended.ts:15
- Draft comment:
Removal of the legacy languageOptions (ECMAScript 2018 and module type) is appropriate per issue #366. This change prevents unwanted lint errors for newer ECMAScript features. Ensure that the breaking change is mentioned in the release notes so that users explicitly setting their language options are aware of the update. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure that a breaking change is mentioned in the release notes. This falls under the category of asking the author to update documentation or descriptions, which is against the rules. Therefore, this comment should be removed.
Workflow ID: wflow_T89FskiydLt4zk3B
You can customize 
Signed-off-by: JounQin <admin@1stg.me>
JounQin
changed the title
languageOptions config from flat/recommended
commit: |
JounQin
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent showing linting errors on code that relies on ECMAScript features implemented after 2018.
If a user wants to limit the ECMAScript version to use, it should set that on his config.
Fixes #366.
Important
Removes
languageOptionsfromrecommended.tsto allow ECMAScript features post-2018 without linting errors, fixing issue #366.languageOptionsfromrecommended.ts, allowing ECMAScript features post-2018 without linting errors.This description was created by
for 049554a. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit