Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-extraneous-dependencies): correct some Options type properties #174

Merged

Conversation

marcalexiei
Copy link

no-extraneous-dependencies rule Options type contains incorrect definition for the following properties:

  • devDependencies
  • optionalDependencies
  • peerDependencies
  • bundledDependencies

They should be boolean | string[] as stated in the rule schema below:

devDependencies: { type: ['boolean', 'array'] },
optionalDependencies: { type: ['boolean', 'array'] },
peerDependencies: { type: ['boolean', 'array'] },
bundledDependencies: { type: ['boolean', 'array'] },

Copy link

changeset-bot bot commented Nov 2, 2024

🦋 Changeset detected

Latest commit: c375696

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-import-x Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Nov 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Collaborator

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SukkaW SukkaW merged commit e01dce0 into un-ts:master Nov 10, 2024
21 checks passed
@marcalexiei marcalexiei deleted the no-extraneous-dependencies-options-type-fix branch November 13, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants