Fix incorrect no-duplicates prefer-inline default type import handling #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d5ff0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
LGTM, I have approved the CI! |
SukkaW
approved these changes
Sep 29, 2024
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Sep 29, 2024
##### [v4.3.1](https://github.com/un-ts/eslint-plugin-import-x/blob/HEAD/CHANGELOG.md#431) ##### Patch Changes - [#162](un-ts/eslint-plugin-import-x#162) [`38d0081`](un-ts/eslint-plugin-import-x@38d0081) Thanks [@AaronMoat](https://github.com/AaronMoat)! - Fix issue where `no-duplicates` rule with `prefer-inline` incorrectly marks default type and named type imports as duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue in one of my repositories with Koa:
The rule was rewriting it to invalid syntax:
One approach could be just to allow it to:
However, I don't think this plugin should be changing type imports into value imports in this scenario.
Therefore, after this change, it leaves the imports alone. I hope this should be not too controversial given it was previously producing invalid syntax.
I am of course not an expert in this code :) but the change seems suspiciously simple. Are there any additional test cases I can add to help verify this?