Drop AppFormBuilder
#457
Open
Drop AppFormBuilder
#457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving towards #89. Tackling this first because it will make solving that easier.
This addition we inject into the Rails form builders is just a partial in disguise. The JS here has gotten a little looser in terms of locating what we're changing, but this JS should only ever interface with the code in the
_with_increment_buttonspartial. The existing code is functional, but it is not nearly as flexible as rails internals are (i.e. when dealing with #89, our form builder will try to callobstacle_89on form elements).We can continue to maintain this custom version of a number field, or we can just drop it and delegate more work off to Rails. (I think my preference is clear)