Switch to swiftly GTFS and drop InfoPoint #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmelz
requested changes
Jun 25, 2025
|
Apologies for the nasty diff in |
benmelz
requested changes
Jun 26, 2025
src/utils/publicMessagesFromGtfs.js
Outdated
| // them out. Alerts are prototyped, so blank route ids end up being empty strings. So we will end up filtering | ||
| // out agency wide alerts without that second conditional. | ||
| gtfsEntities = gtfsEntities.filter((gtfsEntity) => { | ||
| return gtfsEntity.alert.informedEntity.every((entity) => entity.routeId in routesGtfsMap) || |
There was a problem hiding this comment.
Suggested change
| return gtfsEntity.alert.informedEntity.every((entity) => entity.routeId in routesGtfsMap) || | |
| return gtfsEntity.alert.informedEntity.some((entity) => entity.routeId in routesGtfsMap) || |
It just occurred to me - what if the long-running alert applies to one route that stays and one route that is removed from the schedule? We'd probably want to keep that alert at this stage?
I think this would have to be paired with another adjustment I'm gonna suggest below
src/utils/publicMessagesFromGtfs.js
Outdated
| alert: { | ||
| ...gtfsAlert.alert, | ||
| ...gtfsEntity.alert, | ||
| informedEntity: routeIds.map((routeId) => routesGtfsMap[routeId]) |
There was a problem hiding this comment.
Suggested change
| informedEntity: routeIds.map((routeId) => routesGtfsMap[routeId]) | |
| informedEntity: routeIds.map((routeId) => routesGtfsMap[routeId]).filter((route) => route) |
i.e. if we didn't get an actual route from the routeMap, discard it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #224 and swap out our implementation of GTFS hooks for our gtfs-react-hooks package.