Add keyboard detection to spam filters #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation adds the ability to detect and flag messages with attached keyboards (buttons) as spam. - Add HasKeyboard field to MetaData struct - Update Message struct with WithKeyboard flag - Detect keyboards in the transform function - Add KeyboardCheck meta check function - Add configuration option in main.go - Update webapi settings - Add tests for keyboard detection Fixes #258
Deploying tg-spam with
|
| Latest commit: |
aa94af6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccae0396.tg-spam.pages.dev |
| Branch Preview URL: | https://feature-keyboard-detection.tg-spam.pages.dev |
There was a problem hiding this comment.
PR Overview
This PR adds keyboard detection to spam filters by implementing a new KeyboardCheck meta check function and updating related data structures, configuration, and tests.
- Implements KeyboardCheck in the meta checks framework.
- Adds configuration flags, request field propagation, and tests for keyboard detection.
- Updates event handling and settings to support the new keyboard detection feature.
Reviewed Changes
| File | Description |
|---|---|
| lib/tgspam/metachecks_test.go | Adds tests for the new KeyboardCheck meta check |
| lib/tgspam/metachecks.go | Implements the KeyboardCheck meta check function |
| app/main.go | Updates configuration to include a new keyboard flag |
| app/events/events.go | Adds keyboard detection logic based on attached button markups |
| lib/spamcheck/spamcheck.go | Updates Request string formatting to include the has_keyboard flag |
| app/bot/bot.go | Adds WithKeyboard field to the bot message struct |
| app/bot/spam.go | Propagates the keyboard flag from bot messages to the spam check request |
| lib/spamcheck/spamcheck_test.go | Updates tests to verify proper handling of the keyboard field |
| app/webapi/webapi.go | Updates Settings struct to include the MetaKeyboard flag |
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
umputun
added a commit
that referenced
this pull request
Mar 6, 2025
- Display keyboard detection setting in the Meta Checks section of the settings page - The feature was added in PR #259 but was missing from the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #258