Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple improvements to CI #1846

Merged
merged 5 commits into from
Nov 10, 2024
Merged

Multiple improvements to CI #1846

merged 5 commits into from
Nov 10, 2024

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Nov 10, 2024

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Example where you can see it: https://github.com/umputun/remark42/actions/runs/11750590888

Other commits fix small stuff like that. Also, drop arm/v7 docker image for website as it's broken for quite some time, stuck on yarn package installation step: https://github.com/umputun/remark42/actions/workflows/ci-site.yml?query=branch%3Amaster

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
@paskal paskal marked this pull request as ready for review November 10, 2024 21:39
@paskal paskal requested a review from umputun as a code owner November 10, 2024 21:39
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.24%. Comparing base (b557915) to head (f6670c3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##            master    #1846       +/-   ##
============================================
- Coverage   100.00%   64.24%   -35.76%     
============================================
  Files            8      140      +132     
  Lines          232     3230     +2998     
  Branches        58      773      +715     
============================================
+ Hits           232     2075     +1843     
- Misses           0     1151     +1151     
- Partials         0        4        +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 10, 2024

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 73.5 KB (0%)
public/remark.css 8.26 KB (0%)
public/last-comments.mjs 35.75 KB (0%)
public/last-comments.css 3.75 KB (-0.03% 🔽)
public/deleteme.mjs 12.07 KB (0%)
public/counter.mjs 751 B (0%)

@paskal paskal force-pushed the paskal/remove-deprecated-func branch from bee6cfb to 1be053e Compare November 10, 2024 21:43
@paskal paskal changed the title Remove deprecated set-output function usage in GitHub actions Multiple improvements to CI Nov 10, 2024
@umputun umputun merged commit 3646c4a into master Nov 10, 2024
11 of 12 checks passed
@umputun umputun deleted the paskal/remove-deprecated-func branch November 10, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants