Skip to content

Commit

Permalink
Update pnpm from v7 to v8
Browse files Browse the repository at this point in the history
That suppose to help with Dependabot security updates not updating lockfile.
  • Loading branch information
paskal committed Nov 10, 2024
1 parent 63048cc commit b02935b
Show file tree
Hide file tree
Showing 11 changed files with 2,187 additions and 2,062 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci-frontend-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
uses: pnpm/action-setup@v4.0.0
id: pnpm-install
with:
version: 7
version: 8
run_install: false

- name: Get pnpm store directory
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
uses: pnpm/action-setup@v4.0.0
id: pnpm-install
with:
version: 7
version: 8
run_install: false

- name: Get pnpm store directory
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
uses: pnpm/action-setup@v4.0.0
id: pnpm-install
with:
version: 7
version: 8
run_install: false

- name: Get pnpm store directory
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
uses: pnpm/action-setup@v4.0.0
id: pnpm-install
with:
version: 7
version: 8
run_install: false

- name: Get pnpm store directory
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
uses: pnpm/action-setup@v4.0.0
id: pnpm-install
with:
version: 7
version: 8
run_install: false

- name: Get pnpm store directory
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
uses: pnpm/action-setup@v4.0.0
id: pnpm-install
with:
version: 7
version: 8
run_install: false

- name: Get pnpm store directory
Expand Down Expand Up @@ -161,7 +161,7 @@ jobs:
uses: pnpm/action-setup@v4.0.0
id: pnpm-install
with:
version: 7
version: 8
run_install: false

- name: Check bundle size
Expand Down Expand Up @@ -191,7 +191,7 @@ jobs:
uses: pnpm/action-setup@v4.0.0
id: pnpm-install
with:
version: 7
version: 8
run_install: false

- name: Get pnpm store directory
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ COPY ./frontend/apps/remark42/package.json /srv/frontend/apps/remark42/
RUN \
if [[ -z "$SKIP_FRONTEND_BUILD" || -z "$SKIP_FRONTEND_TEST" ]]; then \
apk add --no-cache --update git && \
npm i -g pnpm@7; \
npm i -g pnpm@8; \
fi

RUN --mount=type=cache,id=pnpm,target=/root/.pnpm-store/v3 \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.artifacts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ WORKDIR /srv/frontend
COPY ./frontend/package.json ./frontend/pnpm-lock.yaml ./frontend/pnpm-workspace.yaml /srv/frontend/
COPY ./frontend/apps/remark42/package.json /srv/frontend/apps/remark42/package.json

RUN apk add --no-cache --update git && npm i -g pnpm@7
RUN apk add --no-cache --update git && npm i -g pnpm@8
RUN --mount=type=cache,id=pnpm,target=/root/.pnpm-store/v3 pnpm i

FROM frontend-deps AS build-frontend
Expand Down
2 changes: 1 addition & 1 deletion frontend/Dockerfile.e2e
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ WORKDIR /frontend

COPY ./package.json ./pnpm-workspace.yaml ./pnpm-lock.yaml /frontend/
COPY ./e2e/package.json /frontend/e2e/
RUN corepack enable && corepack prepare pnpm@7.33.6 --activate && pnpm install
RUN corepack enable && corepack prepare pnpm@8 --activate && pnpm install

COPY ./e2e/playwright.config.ts /frontend/e2e/
COPY ./e2e/tests /frontend/e2e/tests/
Expand Down
6 changes: 3 additions & 3 deletions frontend/apps/remark42/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
"translation:check": "node ./tasks/checkTranslation.js"
},
"engines": {
"node": ">=16.15 <=17.*",
"pnpm": "7.*"
"node": ">=16.15 <=22.*",
"pnpm": "8.*"
},
"packageManager": "pnpm@7.33.7",
"packageManager": "pnpm@8.15.9",
"dependencies": {
"@github/markdown-toolbar-element": "^2.1.1",
"@github/text-expander-element": "^2.2.2",
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"type-check:api": "turbo run type-check --filter=@remark42/api",
"lint:api": "turbo run lint --filter=@remark42/api"
},
"packageManager": "pnpm@7.33.7",
"packageManager": "pnpm@8.15.9",
"devDependencies": {
"husky": "^8.0.1",
"lint-staged": "^13.0.3",
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Implementation of API methods for Remark42

## Development

- If you don't have `pnpm` installed run `npm i -g pnpm@7`
- If you don't have `pnpm` installed run `npm i -g pnpm@8`
- Install dependencies `pnpm i`
- Run development mode with `pnpm run dev`
- Build lib with `pnpm run build`
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"type-check": "tsc --noEmit",
"lint-staged:lint": "eslint --fix --ext .cjs,.mjs,.ts"
},
"packageManager": "pnpm@7.33.7",
"packageManager": "pnpm@8.15.9",
"devDependencies": {
"@types/node": "^18.0.5",
"@typescript-eslint/eslint-plugin": "^5.33.1",
Expand Down
Loading

0 comments on commit b02935b

Please sign in to comment.