Allow to skip sg egress rules creation #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really waiting for this. :) |
IrmantasMarozas
force-pushed
the
feature/optional-egress-rule
branch
from
f73b82a to
8bd7577
Compare
IrmantasMarozas
force-pushed
the
feature/optional-egress-rule
branch
from
8bd7577 to
2d23267
Compare
Ohid25
approved these changes
Apr 20, 2023
|
Thank you for your contribution! This is now a part of the 3.3.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, Redis doesn't need to have egress rules. Forcing to have egress rule open to the world flags a vulnerability by many security scanning tools.
https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/TroubleshootingConnections.html#Security_groups