Refactored container definitions out of module #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ohid25
added
documentation
Mohammed-afk91
previously approved these changes
Mar 21, 2023
Ohid25
force-pushed
the
feature/refactor_container_definitions
branch
from
6353756 to
ef15dae
Compare
added 10 commits
April 11, 2023 12:50
Reason: if the creation of cloudwatch logs happens outside of this module, then that can be passed into the container definitions variable
Despite turning cloudwatch group resource as optional, the module will still expect a log group arn
Ohid25
force-pushed
the
feature/refactor_container_definitions
branch
from
8b0aa54 to
97df639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored container definitions out of the module. We find that it will be easier to dedicate modules that have a more elegant solution to container definitions rather than us having to retrofit our heredoc version of the container definitions.
We've kept the functionality of the current container definition, but this will eventually be refactored entirely out, making subsequent changes from here on out a breaking change.
BREAKING CHANGE
enable_logstofalseterraform state mvcommands to ensure no Cloudwatch logs get recreated/destroyed