Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: watch ignored outputPath #5422

Merged
merged 3 commits into from
Sep 16, 2020
Merged

fix: watch ignored outputPath #5422

merged 3 commits into from
Sep 16, 2020

Conversation

xiaohuoni
Copy link
Member

原因是以 dist 开头的文件被忽略了。

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@xiaohuoni xiaohuoni requested a review from ycjcl868 September 15, 2020 09:25
@ycjcl868
Copy link
Contributor

ci ，哎

@ycjcl868 ycjcl868 self-assigned this Sep 15, 2020
@xiaohuoni
Copy link
Member Author

ci
image

@sorrycc
Copy link
Member

sorrycc commented Sep 15, 2020

感觉改地不对，

  1. node_modules 不加 ^ 和 $ 才是符合预期的
  2. outputPath 感觉可以用绝对路径来匹配，可以试试 absOutputPath
  3. 记得验证下各个场景

@ycjcl868 path.sep 如果用了也记得验证，加 sep 不一定对，如果 path 做过 winPath 的处理，path.sep 反而匹配不上。

@sorrycc
Copy link
Member

sorrycc commented Sep 16, 2020

@ycjcl868 pr 的 tag 用 pr 开头，比如 pr(bug)。

@sorrycc sorrycc added pr(bug) and removed type(bug) labels Sep 16, 2020
@sorrycc sorrycc merged commit b305b9c into master Sep 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-watch-ignored-outputPath branch September 16, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycjcl868 ycjcl868 ycjcl868 left review comments

Assignees

@ycjcl868 ycjcl868

Labels
pr(bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

路径中不能包含“distributor”英文单词？
3 participants
@xiaohuoni @ycjcl868 @sorrycc